fix(api): Remove double logging of Bridge errors #6864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We log once in ExecuteBridgeRequest so there is no need to log the error again in get-bridge-status.usecase.ts
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
commented
Nov 5, 2024
| @@ -50,13 +50,11 @@ export class BridgeController { | |||
| @Get('/status') | |||
| @UseGuards(UserAuthGuard) | |||
| async health(@UserSession() user: UserSessionData) { | |||
| const result = await this.getBridgeStatus.execute( | |||
| return this.getBridgeStatus.execute( | |||
There was a problem hiding this comment.
Note that the HealthCheck type has a status error and is not currently used.
As part of future work, we will discuss whether Bridge errors must return a HealthCheck payload with status set to 'error'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
We log once in ExecuteBridgeRequest, so there is no need to log the error again in
get-bridge-status.usecase.tsScreenshots
The fix should remove the log entry in the red-dotted box
